Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmem: add package #5430

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

libmem: add package #5430

wants to merge 7 commits into from

Conversation

luadebug
Copy link

@luadebug luadebug commented Oct 6, 2024

[libmem] add new port

@luadebug luadebug changed the title [libmem] add new port libmem: add package Oct 6, 2024
Minor changes
Removed unused flags.
add_versions("5.0.2", "99adea3e86bd3b83985dce9076adda16968646ebd9d9316c9f57e6854aeeab9c")
add_deps("cmake")

-- Installation instructions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释去掉

Copy link
Author

@luadebug luadebug Oct 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done…? 72d8d1d

-- Set the build configuration parameters
local configs = {}

io.writefile("xmake.lua", [[
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

复杂的配置,挪到 port/xmake.lua 独立文件维护,参考其他包

Copy link
Author

@luadebug luadebug Oct 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏳️🏳️🏳️
I wish I could do that, but libmem s repository refers to non-existing repositories branches I believe. Legacy
It will take a lot of time to port complete meaningless dependencies onto xrepo in that case.
Maybe I have misunderstood your review, idea behind context is to make some file to store stuff that is being used by io.writefile???

]])
-- Use xmake to build and install libmem
import("package.tools.xmake").install(package, configs)
end)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缺少 on_test

Copy link
Author

@luadebug luadebug Oct 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏳️🏳️🏳️
I do not have idea how to make a one. I think it will never find libmem/libmem.h or libmem/libmem.hpp either to start a test…

set_description("Advanced Game Hacking Library for C, Modern C++, Rust and Python (Windows/Linux/FreeBSD) (Process/Memory Hacking) (Hooking/Detouring) (Cross Platform) (x86/x64/ARM/ARM64) (DLL/SO Injection) (Internal/External) (Assembler/Disassembler)")
set_license("AGPL-3.0")

add_urls("https://github.com/rdbo/libmem.git", {submodules = true})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有 tar url ,加上。还有对应的 sha256

Copy link
Author

@luadebug luadebug Oct 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added tar link 33b6d0d, but what is sha256 about?
Could it be

add_versions("5.0.2", "99adea3e86bd3b83985dce9076adda16968646ebd9d9316c9f57e6854aeeab9c")

That I have added recently?

package("libmem")

set_homepage("https://github.com/rdbo/libmem")
set_description("Advanced Game Hacking Library for C, Modern C++, Rust and Python (Windows/Linux/FreeBSD) (Process/Memory Hacking) (Hooking/Detouring) (Cross Platform) (x86/x64/ARM/ARM64) (DLL/SO Injection) (Internal/External) (Assembler/Disassembler)")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

简化下描述

Copy link
Author

@luadebug luadebug Oct 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done…? bff94dc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants